Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JT V3 edits #3759

Merged
merged 18 commits into from
Dec 21, 2024
Merged

JT V3 edits #3759

merged 18 commits into from
Dec 21, 2024

Conversation

JessamyT
Copy link
Collaborator

@JessamyT JessamyT commented Dec 12, 2024

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Dec 12, 2024
@JessamyT JessamyT changed the base branch from main to v3.0 December 12, 2024 02:36
@viambot
Copy link
Member

viambot commented Dec 12, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3759

@JessamyT JessamyT force-pushed the jtv3 branch 2 times, most recently from 1e1275b to 2e58971 Compare December 17, 2024 19:48
Copy link
Collaborator Author

@JessamyT JessamyT Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npentrel This page is an example of where it'd be really handy, at least for now, to keep some version of a tutorials or how-tos page in the dev tools section, that can be linked to from different pages. I initially put it here inside /mobile-app/ because I wanted to use this content as an example and not have it completely deleted. But that doesn't quite make sense since it also has the other languages. I could strip out the other languages and just use a flutter version of it here if necessary, but if we are keeping tutorials in dev-tools I'm thinking I'd like to move it into tutorials and just link to it from here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I think moving to tutorials is an option. The other option is to do something similar to the "Advanced" headers in the AI & Data section and name it "Examples". Move forward with whichever you think is best for now

@@ -5,5 +5,5 @@ weight: 20
layout: "docs"
type: "docs"
no_list: true
description: "TODO"
description: "Spatially describe your robot's working environment for collision avoidance."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robot or machine?

Copy link
Collaborator Author

@JessamyT JessamyT Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as below; I think "robot" evokes the right image in this context, and we don't need to be as broad as "machine" because a little IoT sensor device doesn't need collision avoidance.

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, I've left feedback on the things I reviewied, I didn't look at the cpp module and micro-rdk module pages since I assume they're largely the same or will stay in draft mode anyway

@@ -5,5 +5,5 @@ weight: 40
layout: "docs"
type: "docs"
no_list: true
description: "TODO"
description: "Move a mobile robot with manual or autonomous navigation."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robot or machine?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think robot is good in this context because "machines" that move around are often thought of as robots, and this is the non-Viam-specific way to describe the task. There are exceptions, but I think "robot" will create the best understanding in this case.

weight: 10
layout: "docs"
type: "docs"
no_list: true
description: "TODO"
description: "Create a custom user interface for interacting with machines from a browser."
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll want something for setting up the typescript SDK as well, even if it's just instructions to go to the connect tab and follow the instructions there. This is currently missing the pragmatic instruction for what to do next

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right good point.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done--lmk what you think

docs/operate/control/headless-app.md Outdated Show resolved Hide resolved
docs/operate/control/headless-app.md Outdated Show resolved Hide resolved
docs/operate/control/headless-app.md Outdated Show resolved Hide resolved
docs/operate/get-started/supported-hardware.md Outdated Show resolved Hide resolved
When you add a modular resource _from the registry_, the module that provides it is automatically added at the same time, generating a configuration card for the modular resource and a separate one for the module.
If you add a built-in component, there will only be a configuration card for the component.

### Modular resource configuration details
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether this and the module config details should stay in reference content. I think most of the time this info here (and the info for module config) will only be used as reference.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Will move.

Comment on lines 27 to 38
{{% alert title="In this page" color="tip" %}}

- [What hardware is already supported?](#supported-hardware)
- [Add supported hardware to my machine's configuration](#configure-hardware-on-your-machine)

{{% /alert %}}

{{% alert title="See also" color="tip" %}}

- [Support other hardware by creating a new module](../other-hardware/)

{{% /alert %}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may want to remove these. You may also want to postpone explaining virtual hardware till later on the page. It currently takes too long to get to the part where you do things

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it into a little details expander-LMK what you think of that.

docs/operate/get-started/other-hardware/_index.md Outdated Show resolved Hide resolved
@JessamyT JessamyT marked this pull request as ready for review December 21, 2024 08:03
@JessamyT JessamyT merged commit 1764121 into viamrobotics:v3.0 Dec 21, 2024
3 of 7 checks passed
@JessamyT JessamyT deleted the jtv3 branch December 28, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants