Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP-7004] Implement ListOAuthApplications CLI Command #4646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[APP-7004] Implement ListOAuthApplications CLI Command #4646

wants to merge 1 commit into from

Conversation

JosephBorodach
Copy link

@JosephBorodach JosephBorodach commented Dec 19, 2024 •
edited
Loading

Description

See ticket here

Org with an auth app

viam/rdk - (APP-7004-Implement-ListOAuthApplications-CLI-Command) > go run cli/viam/main.go organizations list-oauth-apps --org-id 81d727e5-176a-4d3e-8f69-87f01ba30125
OAuth apps for organization "81d727e5-176a-4d3e-8f69-87f01ba30125":

 - 8810e3ff-89a6-4320-b532-88ac24196f86

Org without an auth app

go run cli/viam/main.go organizations list-oauth-apps --org-id 9c9243cb-6d3a-4aee-914c-a49b43821463
No OAuth apps found for organization "9c9243cb-6d3a-4aee-914c-a49b43821463"

@JosephBorodach JosephBorodach requested a review from a team as a code owner December 19, 2024 15:20
@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Dec 19, 2024
@JosephBorodach JosephBorodach force-pushed the APP-7004-Implement-ListOAuthApplications-CLI-Command branch from 7147156 to 9c9948f Compare December 19, 2024 15:24
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 19, 2024
@JosephBorodach JosephBorodach force-pushed the APP-7004-Implement-ListOAuthApplications-CLI-Command branch from 9c9948f to 1af5323 Compare December 20, 2024 16:07
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 20, 2024
@JosephBorodach JosephBorodach force-pushed the APP-7004-Implement-ListOAuthApplications-CLI-Command branch from 1af5323 to 8e62805 Compare December 20, 2024 16:12
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 20, 2024
@JosephBorodach JosephBorodach force-pushed the APP-7004-Implement-ListOAuthApplications-CLI-Command branch from 8e62805 to 4dc0a89 Compare December 20, 2024 16:51
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 20, 2024
@JosephBorodach JosephBorodach requested a review from jr22 December 20, 2024 18:30
jr22
jr22 reviewed Dec 20, 2024
View reviewed changes
cli/app.go
@@ -465,6 +465,18 @@ var app = &cli.App{
},
},
},
{
Name: "list-oauth-apps",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want this to be the command? or should it be something like organization oauth list so we can also have organization oauth create etc.

would check scope and check with @maxhorowitz

jr22
jr22 reviewed Dec 20, 2024
View reviewed changes
cli/client.go
OrgID string
}

// ListOAuthAppsAction corresponds to `list-oauth-apps`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tests in client_test too pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jr22 jr22 jr22 left review comments

@stuqdog stuqdog stuqdog approved these changes

@lia-viam lia-viam Awaiting requested review from lia-viam lia-viam is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JosephBorodach @CLAassistant @jr22 @stuqdog @viambot