warning: redundant pattern matching, consider using `is_ok()` --> src/dialdbg/main.rs:326:16 | 326 | if let Ok(_) = log_path.try_exists() { | -------^^^^^------------------------ help: try: `if log_path.try_exists().is_ok()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

warning: redundant pattern matching, consider using `is_ok()` --> src/dialdbg/main.rs:258:16 | 258 | if let Ok(_) = log_path.try_exists() { | -------^^^^^------------------------ help: try: `if log_path.try_exists().is_ok()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default

warning: length comparison to zero --> src/dialdbg/main.rs:152:8 | 152 | if responses.len() == 0 { | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `responses.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

warning: you seem to want to iterate on a map's values --> src/dialdbg/stats.rs:13:27 | 13 | for (_, value) in &self.0.reports { | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map = note: `#[warn(clippy::for_kv_map)]` on by default help: use the corresponding method | 13 | for value in self.0.reports.values() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~

warning: length comparison to zero --> src/dialdbg/parse.rs:159:8 | 159 | if split_log.len() == 0 { | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `split_log.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default

warning: constants have by default a `'static` lifetime --> src/dialdbg/parse.rs:10:38 | 10 | pub(crate) const DIAL_ERROR_PREFIX: &'static str = "unexpected dial connect error"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default

warning: needlessly taken reference of both operands --> src/rpc/dial.rs:884:32 | 884 | let average_duration = &self.total_duration.as_millis() / &self.count; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default help: use the values directly | 884 | let average_duration = self.total_duration.as_millis() / self.count; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~

warning: use of `or_insert` to construct default value --> src/rpc/dial.rs:403:30 | 403 | map.entry(k).or_insert(vec![]).push(v); | ^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

warning: passing a unit value to a function --> src/rpc/client_stream.rs:114:47 | 114 | Some(Type::Trailers(trailers)) => Ok(self.process_trailers(trailers.to_owned()).await), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg = note: `#[warn(clippy::unit_arg)]` on by default help: move the expression in front of the call and replace it with the unit literal `()` | 114 ~ Some(Type::Trailers(trailers)) => { 115 + self.process_trailers(trailers.to_owned()).await; 116 + Ok(()) 117 ~ }, |

warning: doc list item without indentation --> src/gen/google.api.rs:195:5 | 195 | /// request body, all | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 195 | /// request body, all | +++

warning: doc list item without indentation --> src/gen/google.api.rs:192:5 | 192 | /// query parameter, all fields | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 192 | /// query parameter, all fields | +++

warning: doc list item without indentation --> src/gen/google.api.rs:185:5 | 185 | /// are passed via the HTTP | ^^^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 185 | /// are passed via the HTTP | ++

warning: empty doc comment --> src/gen/proto.rpc.examples.echoresource.v1.tonic.rs:237:5 | 237 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echoresource.v1.tonic.rs:228:9 | 228 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echoresource.v1.tonic.rs:211:9 | 211 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echoresource.v1.tonic.rs:194:9 | 194 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echoresource.v1.tonic.rs:152:9 | 152 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echoresource.v1.tonic.rs:119:9 | 119 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echoresource.v1.tonic.rs:88:9 | 88 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echoresource.v1.tonic.rs:7:5 | 7 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echo.v1.tonic.rs:212:5 | 212 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echo.v1.tonic.rs:206:9 | 206 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echo.v1.tonic.rs:192:9 | 192 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echo.v1.tonic.rs:181:9 | 181 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echo.v1.tonic.rs:144:9 | 144 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echo.v1.tonic.rs:113:9 | 113 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echo.v1.tonic.rs:88:9 | 88 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs

warning: empty doc comment --> src/gen/proto.rpc.examples.echo.v1.tonic.rs:7:5 | 7 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs = note: `#[warn(clippy::empty_docs)]` on by default

warning: empty line after doc comment --> src/ffi/spatialmath/vector3.rs:8:1 | 8 | / /// from other languages 9 | | | |_ ... 12 | pub(crate) fn to_raw_pointer(vec: Vector3<f64>) -> *mut Vector3<f64> { | -------------------------------------------------------------------- the comment documents this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 9 | /// |

warning: empty line after doc comment --> src/ffi/spatialmath/rotation_matrix.rs:6:1 | 6 | / /// from other languages. These are 3D rotations (so members of SO(3)) 7 | | | |_ ... 10 | fn to_raw_pointer(rot: &Rotation3<f64>) -> *mut Rotation3<f64> { | -------------------------------------------------------------- the comment documents this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 7 | /// |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/ffi/spatialmath/quaternion.rs:275:20 | 275 | to_raw_pointer(&quat) | ^^^^^ help: change this to: `quat` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: empty line after doc comment --> src/ffi/spatialmath/quaternion.rs:15:1 | 15 | / /// from this library 16 | | | |_ ... 19 | fn to_raw_pointer(quat: &Quaternion<f64>) -> *mut Quaternion<f64> { | ----------------------------------------------------------------- the comment documents this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 16 | /// |

warning: empty line after doc comment --> src/ffi/spatialmath/orientation_vector.rs:18:1 | 18 | / /// vector directly and to convert to quaternions via the FFI interface instead 19 | | | |_ ... 22 | fn to_raw_pointer(o_vec: &OrientationVector) -> *mut OrientationVector { | ---------------------------------------------------------------------- the comment documents this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 19 | /// |

warning: empty line after doc comment --> src/ffi/spatialmath/euler_angles.rs:11:1 | 11 | / /// angles directly and to convert to quaternions via the FFI interface instead 12 | | | |_ ... 15 | fn to_raw_pointer(ea: &EulerAngles) -> *mut EulerAngles { | ------------------------------------------------------- the comment documents this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 12 | /// |

warning: empty line after doc comment --> src/ffi/spatialmath/axis_angle.rs:9:1 | 9 | / /// theta about that axis). 10 | | | |_ ... 13 | fn to_raw_pointer(aa: &AxisAngle) -> *mut AxisAngle { | --------------------------------------------------- the comment documents this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default = help: if the empty line is unintentional remove it help: if the documentation should include the empty line include it in the comment | 10 | /// |

warning: non-binding `let` on a future --> src/ffi/dial_ffi.rs:266:5 | 266 | / let _ = runtime.spawn(async { 267 | | let _ = server.await; 268 | | }); | |_______^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future = note: `#[warn(clippy::let_underscore_future)]` on by default

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:22:34 | 22 | pub const ICE_CONNECTED_EXTERN: &'static str = "ICE connection state changed: connected"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:18:32 | 18 | pub const CANDIDATE_SELECTED: &'static str = "Selected candidate pair"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:16:27 | 16 | pub const DIALED_WEBRTC: &'static str = "Connected via WebRTC"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:15:25 | 15 | pub const DIALED_GRPC: &'static str = "Connected via gRPC"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:14:26 | 14 | pub const DIAL_ATTEMPT: &'static str = "Dialing"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:12:43 | 12 | pub const END_LOCAL_SESSION_DESCRIPTION: &'static str = "End local session description"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:11:45 | 11 | pub const START_LOCAL_SESSION_DESCRIPTION: &'static str = "Start local session description"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:9:33 | 9 | pub const ACQUIRED_AUTH_TOKEN: &'static str = "Acquired auth token"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:8:34 | 8 | pub const ACQUIRING_AUTH_TOKEN: &'static str = "Acquiring auth token"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:6:32 | 6 | pub const MDNS_ADDRESS_FOUND: &'static str = "Found address via mDNS"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/log_prefixes.rs:5:32 | 5 | pub const MDNS_QUERY_ATTEMPT: &'static str = "Starting mDNS query"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

warning: constants have by default a `'static` lifetime --> src/rpc/dial.rs:59:36 | 59 | pub const VIAM_MDNS_SERVICE_NAME: &'static str = "_rpc._tcp.local"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default