Mo deeper - Improved 808 Kick sound #19
Conversation
| } |
There was a problem hiding this comment.
The work here does sound a lot more like the original, nice work!
| @@ -32,7 +32,7 @@ export default function (audioCtx, destination, time, { level, tone, snappy }) { | |||
| outputVCA.amplitude.value = outputLevel; | |||
|
|
|||
| // envelopes | |||
| const noiseEnv = new ADGenerator(LINEAR, 0.1, 75, 0, 0.5); | |||
| const noiseEnv = new ADGenerator(LINEAR, 0.1, 160, 0, 0.9); | |||
There was a problem hiding this comment.
I really think that this is too long of a decay time. The decay time on the snare is documented to be 60ms, and I had just nudged it a bit up to 75ms to account for the differences in the envelope curves.
There was a problem hiding this comment.
I would trust ears over eyes. If you listen to actual 808 Snare it has a much longer sounding decay
There was a problem hiding this comment.
If you look at the waveforms you can see that the original 808 sample trails off much longer, around 260ms
vs your snare around 130ms
This is just to illustrate the sample behavior. I feel the snare needs a lot of work. It really sounds nothing like a real 808 snare. IMHO it's better to make something that SOUNDS more like an 808 in practice than trying to match specs that really don't hold true anyway. Analog gears have many anomalies including the pre-amp and filters etc that also effect the sound. When I have time I will see how I can further improve the sound of the snare and other instruments. But sound improvement / design is always subjective.
There was a problem hiding this comment.
Is there anything in the code that mimics the subtle nuances of the bridged T-Network components used in both the Kick and Snare sounds of a real 808? If not, I think we can agree that just setting basic ADSR envelops to certain specs probably won't do the trick. We also don't know what frequencies are used and so again I think we're guessing and need to trust our ears. I suppose you've already looked at http://fa.utfs.org/diy/rolandtr808/roland_TR-808_service-manual.pdf
Interesting info here too: https://www.kvraudio.com/forum/viewtopic.php?p=5778538
There was a problem hiding this comment.
In that case the lengthening of the snare's decay time should also go with a change to an EXPONENTIAL type AD envelope. In the case of the bridged-t osc I'm still experimenting with ways to emulate it but haven't had much luck so far.
There was a problem hiding this comment.
I've been tweaking the snare for the last few hrs. trying a few different things.
One thing for sure is that the behavior of Tone and Snappy don't currently resemble the 808 snare. I think I made some progress but not there yet. My approach is to try to understand what sound / dynamics are effected by the sound module. If you totally roll off the snappy on https://codepen.io/lacostenycoder/full/bgbQzX/ for example you'll hear there is no snare rattle tone. So what snappy does really sounds more like it's must mixing in the White noise. I sort of have that part worked out I just pushed update with where I'm out. I have some other ideas I'm gonna try. Are you on Gitter or Slack? Maybe we can hack at this together if you have time. LMK
There was a problem hiding this comment.
Hey it's been a while, were any of the ideas here any help?
Using my ears and A/B testing against a "real" 808 kick, while this isn't an exact match, it's a lot deeper and closer in over impact as the true 808 kick. I attempted to make some progress as well on the snare but I think that needs a more comprehensive overhaul to get it closer to a true 808 snare.