Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get locales from the system #31

Merged

Conversation

lbgracioso
Copy link
Collaborator

Hey! Fast one.

This PR solves the "Get locales from the system" to-do.

A example of PresenterLocale after the changes.
Example

@lbgracioso
Copy link
Collaborator Author

The only thing I don't like, but haven't been able to think of a solution (yet), are the places where you call getLocale twice (getLocale().getLocale()).

This problem also happens with Timezone.

@viniciusferrao
Copy link
Owner

Thank you Lucas. :)

@viniciusferrao viniciusferrao merged commit 589c31f into viniciusferrao:master Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants