fix: Treeland occasionally crash #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x11 applications crash when use because of use null pointer. Log: fixed crash Issue: linuxdeepin/treeland#283
zccrs
requested changes
Jun 4, 2024
| @@ -940,7 +940,7 @@ void WSurfaceItem::onSurfaceCommit() | |||
| // Maybe the beforeRequestResizeSurfaceStateSeq is set by resizeSurfaceToItemSize, | |||
| // the resizeSurfaceToItemSize wants to resize the wl_surface to current size of WSurfaceitem, | |||
| // If change the WSurfaceItem's size at here, you will see the WSurfaceItem flash. | |||
| if (d->beforeRequestResizeSurfaceStateSeq < d->surface->handle()->handle()->current.seq) { | |||
| if (Q_LIKELY(d->surface) && d->beforeRequestResizeSurfaceStateSeq < d->surface->handle()->handle()->current.seq) { | |||
There was a problem hiding this comment.
No, d->surface must is not nullptr here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x11 applications crash when use because of use null pointer.
Log: fixed crash
Issue: linuxdeepin/treeland#283