Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2D Silo PBCs #20194

Open
wants to merge 1 commit into
base: 3.4RC
Choose a base branch
from
Open

Fix 2D Silo PBCs #20194

wants to merge 1 commit into from

Conversation

markcmiller86
Copy link
Member

@markcmiller86 markcmiller86 commented Jan 18, 2025

Description

@cyrush I cannot find the issue associated with this. I thought you had created one?

Apologies for not catching this when original work was done. I would have been very easy to include logic to ensure 2D case was covered. But, I guess I had been assuming that in the 2D case, even if PBCs completely surrounded the mesh, all plotting would still work fine and so it isn't really relevant in 2D.

While that might be true, the code that processes PBC data in the file is still executed and when it got to a point where 3D was assumed, it failed some integrity checks. This just adds the 2D case to those very rudimentary checks.

Type of change

  • Bug fix~~
  • [ ] New feature
  • [ ] Documentation update
  • [ ] Other

How Has This Been Tested?

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

  • I have commented my code where applicable.~~
  • [ ] I have updated the release notes.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have confirmed new and existing unit tests pass locally with my changes.
  • [ ] I have added new baselines for any new tests to the repo.
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant