Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@cyrush I cannot find the issue associated with this. I thought you had created one?
Apologies for not catching this when original work was done. I would have been very easy to include logic to ensure 2D case was covered. But, I guess I had been assuming that in the 2D case, even if PBCs completely surrounded the mesh, all plotting would still work fine and so it isn't really relevant in 2D.
While that might be true, the code that processes PBC data in the file is still executed and when it got to a point where 3D was assumed, it failed some integrity checks. This just adds the 2D case to those very rudimentary checks.
Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
Reminders:
Checklist:
[ ] I have updated the release notes.[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.