Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #151: delta fallback if one of vectors is null #152

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

GrizliK1988
Copy link

Hi @vitalii-andriiovskyi ,

could you please check this one?

Not sure why this issue happens and simply added a fallback. Hope it's fine.

@luchianenco
Copy link

any update when this PR can be reviewed and merged?

@vitalii-andriiovskyi
Copy link
Owner

@luchianenco This PR needs improvements. The fallback should be added to the method difference of CarouselService but not at it's here.

I fixed it. I think I'll publish the library with fix and other improvements within next 3 days. This fix will be in versions of ngx-owl-carousel-o for Angular 10, and later versions.

@GrizliK1988
Copy link
Author

Thank you @vitalii-andriiovskyi !

@luchianenco
Copy link

luchianenco commented Jun 9, 2021

@vitalii-andriiovskyi big thank for the fast reply

@vitalii-andriiovskyi
Copy link
Owner

@GrizliK1988 @luchianenco

Published versions 4.1.0 (for Angular 10) and 5.1.0 (for Angular 11) with fallback. You can install and check whether the issue has gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants