Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix canonical links #19084

Merged
merged 1 commit into from
Dec 28, 2024
Merged

docs: fix canonical links #19084

merged 1 commit into from
Dec 28, 2024

Conversation

sapphi-red
Copy link
Member

Description

Fixes #15984 (comment)

  • dist/guide/index.html should have the canonical url as https://vitejs.dev/guide/
  • dist/guide/features.html should have the canonical url as https://vitejs.dev/guide/features
  • dist/index.html should have the canonical url as https://vitejs.dev (special case where root index.html has no trailing slash)

This PR points dist/index.html to https://vitejs.dev/, but this should be fine as https://vitejs.dev/ and https://vitejs.dev are the same page.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Dec 27, 2024
bluwy
bluwy approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize we had the wrong trailing slash 👀

@sapphi-red sapphi-red merged commit e1b520c into vitejs:main Dec 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @bluwy