Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add clean cache and pull request title validation workflow #3877

Closed
wants to merge 3 commits into from

Conversation

dammy001
Copy link
Member

@dammy001 dammy001 commented Aug 3, 2023

Description

This PR adds

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@stackblitz
Copy link

stackblitz bot commented Aug 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 38d3b73
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/64d07fde7089540008ac6cf8

@sheremet-va
Copy link
Member

I don't really understand the purpose of this PR, to be honest. What cache does it clear and don't we already do that? For PR titles, I don't think we should be too strict there since I can always rename any PR before merging.

@sheremet-va sheremet-va added the p2-to-be-discussed Enhancement under consideration (priority) label Oct 2, 2024
@sheremet-va
Copy link
Member

The team decided that this is not needed. The cache is already in place and we control the name of the PR when merging

@sheremet-va sheremet-va closed this Nov 7, 2024
@sheremet-va sheremet-va removed the p2-to-be-discussed Enhancement under consideration (priority) label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

2 participants