Issue 8044: generic restore - allow to ignore delay binding for WaitForFirstConsumer

[Lyndon-Li]

Fix issue #8044, allow users to ignore delay binding the restorePVC of data mover when it is in WaitForFirstConsumer mode

[codecov]

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.16%. Comparing base (6860dab) to head (cfad06b).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cmd/cli/nodeagent/server.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8550      +/-   ##
==========================================
- Coverage   59.18%   59.16%   -0.02%     
==========================================
  Files         370      370              
  Lines       39591    39605      +14     
==========================================
+ Hits        23433    23434       +1     
- Misses      14677    14689      +12     
- Partials     1481     1482       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[reasonerjt]

I have a trivial comment, if ignoreConsume == true it seems we don't need to enter the Pollxx function, and the code will be slightly easier to read:

	tmpPVC, err := pvcGetter.PersistentVolumeClaims(namespace).Get(ctx, pvc, metav1.GetOptions{})
	if err != nil {
		return false, errors.Wrapf(err, "error to get pvc %s/%s", namespace, pvc)
	}
	if ignoreConsume {
                return "", tmpPVC, nil
        }
	err := wait.PollUntilContextTimeout(ctx, waitInternal, timeout, true, func(ctx context.Context) (bool, error) {
	        	if tmpPVC.Spec.StorageClassName != nil && storageClass == nil {
	        	.....
	        	updated = tmpPVC
	        	return true, nil
	        })
	        return selectedNode, updated, err

[Lyndon-Li]

There is a side benefit with the current code --- we could probe if the targetPVC exists by always calling pvcGetter.PersistentVolumeClaims(namespace).Get. If the targetPVC doesn't exists, we could fail the restore earlier.
For sure, to achieve the same purpose, we could realign the code for better understanding --- adding another pvcGetter.PersistentVolumeClaims(namespace).Get outside of Pollxx, but that will add redundant code.

So let's keep it as is for now.

[reasonerjt]

Approved with a trivial comment.

It can be merged if you don't want to make the change.