[VKCI-192] add token-log-collector utility #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aniruddha Shamasundar <[email protected]>
rocknes
reviewed
Apr 27, 2023
There was a problem hiding this comment.
Do we really need to check in the vendor folder too?
Developers will run go mod tidy/vendor on their copy of checked out code anyways, right?
Is it ok to checkin unsigned binary in the repo? Please ask Arun and Aashima about this.
And if we are ok checking in binaries, let's compile the tool for win, mac and linux.
Reviewable status: 0 of 228 files reviewed, all discussions resolved
ymo24
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
:
Reviewed 14 of 228 files at r1, all commit messages.
Reviewable status: 14 of 228 files reviewed, all discussions resolved
Anirudh9794
changed the title
jjaferson
pushed a commit
to jjaferson/cloud-provider-for-cloud-director
that referenced
this pull request
Dec 11, 2023
* update schema to make org and vdcs array in vcdproperties Signed-off-by: Aniruddha Shamasundar <[email protected]> * Update schema to remove vdc name property Signed-off-by: Aniruddha Shamasundar <[email protected]> * Add tkg version Signed-off-by: Aniruddha Shamasundar <[email protected]> * image change in infrastructure-components Signed-off-by: Aniruddha Shamasundar <[email protected]> * revert image name and update examples Signed-off-by: Aniruddha Shamasundar <[email protected]> * update example for tkgversion Signed-off-by: Aniruddha Shamasundar <[email protected]> * image version change for debug Signed-off-by: Aniruddha Shamasundar <[email protected]> * External ID update fix Signed-off-by: Aniruddha Shamasundar <[email protected]> * Address comments Signed-off-by: Aniruddha Shamasundar <[email protected]> * Remove tkgVersion updates Signed-off-by: Aniruddha Shamasundar <[email protected]> * Update examples Signed-off-by: Aniruddha Shamasundar <[email protected]> Signed-off-by: Aniruddha Shamasundar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility to troubleshoot login related failures
This change is