add application profile annotation support #313
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunmk
reviewed
Nov 3, 2023
pkg/vcdsdk/gateway.go
Outdated
| @@ -1259,6 +1260,10 @@ func (gatewayManager *GatewayManager) CreateVirtualService(ctx context.Context, | |||
| return nil, fmt.Errorf("unhandled virtual service type [%s]", vsType) | |||
| } | |||
|
|
|||
| if len(applicationProfile) != 0 { | |||
There was a problem hiding this comment.
can we do if applicationProfile != "" which is the common pattern in golang
viveksyngh
force-pushed
the
add-app-profile-support
branch
from
9458977 to
e555fd9
Compare
viveksyngh
force-pushed
the
add-app-profile-support
branch
from
e555fd9 to
eb3a2b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is