prosody: update to 0.12.5. #53798
Merged
prosody: update to 0.12.5. #53798
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnInternetTroll
force-pushed
the
user/luca/prosody
branch
from
04515b1 to
b4a0040
Compare
|
sile PR is merged now |
Johnnynator
reviewed
Jan 2, 2025
AnInternetTroll
force-pushed
the
user/luca/prosody
branch
5 times, most recently
from
ed1f802 to
699a6f2
Compare
AnInternetTroll
force-pushed
the
user/luca/prosody
branch
from
699a6f2 to
29eba7d
Compare
Luciogi
reviewed
Jan 4, 2025
srcpkgs/lua54-mediator/template
Outdated
| distfiles="https://github.com/Olivine-Labs/mediator_lua/archive/refs/tags/v${version}-0.tar.gz" | ||
| checksum=faf5859fd2081be4e9e4fb8873a2dc65f7eff3fd93d6dd14da65f8e123fcff9b | ||
|
|
||
| # FIXME: No license is provided by upstream. What do we put in the package? |
There was a problem hiding this comment.
I think so you may copy text from https://opensource.org/license/mit
and paste in file and provide it in package
|
I don't think there's value in shipping these packages for every Lua version. It adds packaging complexity and also duplicates a lot of logic everywhere. If they are needed for lua 5.4, just package them for 5.4. Let somebody who needs them for other Lua versions make the case that we should package them. |
|
On closer inspection, it seems tall of these dependencies, including the apparently dead and improperly licensed |
AnInternetTroll
force-pushed
the
user/luca/prosody
branch
from
29eba7d to
ab80bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Built on x86_64-glibc for aarch64-musl and tested correctly.
Server comes up and I can chat with folks
Opening it now
to have an open PR on January 1stbecause it usessome work from PR #51222. So I want to signal that these 2 PRs use
the same technique (luarocks) for packaging some dependencies.
If the busted package was to not be added then this PR would be much
much smaller, just prosody. But this might be a good time to start
testing the prosody package (and whatever other lua packages that may
want to use busted (but not busted dependencies. Not sure that's a good
idea))