Remove custom navigation registration

vormkracht10 · Sep 6, 2024 · f1c278c · f1c278c
1 parent 0a4d600
commit f1c278c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 24 deletions.
diff --git a/src/FilamentMailsPlugin.php b/src/FilamentMailsPlugin.php
@@ -29,23 +29,7 @@ public function register(Panel $panel): void
 
     public function boot(Panel $panel): void
     {
-        Filament::serving(function () use ($panel) {
-            Filament::registerNavigationItems([
-                NavigationItem::make()
-                    ->group(__('Mails'))
-                    ->label('Mails')
-                    ->url(fn (): string => MailResource::getUrl('index'))
-                    ->icon('heroicon-o-envelope')
-                    ->isActiveWhen(fn (): bool => request()->routeIs('filament.' . $panel->getId() . '.resources.mails.*'))
-                    ->childItems([
-                        NavigationItem::make()
-                            ->label('Events')
-                            ->url(fn (): string => EventResource::getUrl('index'))
-                            ->icon('heroicon-o-calendar')
-                            ->isActiveWhen(fn (): bool => request()->routeIs('filament.' . $panel->getId() . '.resources.events.*')),
-                    ]),
-            ]);
-        });
+        //   
     }
 
     public static function make(): static

diff --git a/src/Resources/EventResource.php b/src/Resources/EventResource.php
@@ -23,7 +23,14 @@ class EventResource extends Resource
 
     protected static bool $isScopedToTenant = false;
 
-    protected static bool $shouldRegisterNavigation = false;
+    protected static bool $shouldRegisterNavigation = true;
+
+    protected static ?string $navigationParentItem = 'Mails';
+
+    public static function getNavigationGroup(): ?string
+    {
+        return __('Mails');
+    }
 
     public static function getNavigationLabel(): string
     {
@@ -35,16 +42,12 @@ public static function getLabel(): ?string
         return __('Events');
     }
 
+
     public static function getNavigationIcon(): string
     {
         return 'heroicon-o-calendar';
     }
 
-    public static function shouldRegisterNavigation(): bool
-    {
-        return false;
-    }
-
     public function getTitle(): string
     {
         return __('Events');

diff --git a/src/Resources/MailResource.php b/src/Resources/MailResource.php
@@ -31,7 +31,12 @@ class MailResource extends Resource
 
     protected static bool $isScopedToTenant = false;
 
-    protected static bool $shouldRegisterNavigation = false;
+    protected static bool $shouldRegisterNavigation = true;
+
+    public static function getNavigationGroup(): ?string
+    {
+        return __('Mails');
+    }
 
     public static function getNavigationLabel(): string
     {