Suppressions list #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acht10/laravel-mails into feature/suppressions-list # Conflicts: # src/Models/MailEvent.php
…acht10/laravel-mails into feature/suppressions-list
…acht10/laravel-mails into feature/suppressions-list
…acht10/laravel-mails into feature/suppressions-list # Conflicts: # src/Models/MailEvent.php
arduinomaster22
force-pushed
the
feature/suppressions-list
branch
from
9489724 to
6a364f4
Compare
arduinomaster22
force-pushed
the
feature/suppressions-list
branch
from
d9231c5 to
55695c6
Compare
markvaneijk
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Omdat we voor het mailEvent moeten weten met welke driver de mail is verzonden, moeten we bij de mails opslaan welke driver de mail verzond. Dit mag dus worden opgeslagen in de database (na de uuid kolom).
Daarnaast moeten we hierbij ook de stream opslaan in de database (voor postmark) zodat we daarmee de unsupress API call kunnen doen. Deze kolom mag dan na de driver kolom.
markvaneijk
requested changes
Jan 13, 2025
database/migrations/3_add_unsuppressed_at_to_mail_events.php.stub
Outdated
Show resolved
Hide resolved
…acht10/laravel-mails into feature/suppressions-list
|
@markvaneijk het enige puntje is nu nog het aanmaken van de stream_id in de DB. Die komt neem ik aan van Postmark af.... Hoe moet dat eruit komen te zien? |
arduinomaster22
force-pushed
the
feature/suppressions-list
branch
from
d6912ef to
a37d7ec
Compare
…acht10/laravel-mails into feature/suppressions-list
…acht10/laravel-mails into feature/suppressions-list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to handle email unsuppression and includes necessary database schema changes, event handling, and updates to mail driver classes. The most important changes are listed below:
Database Migration
unsuppressed_attimestamp inmail_eventstable anddriverandstream_idcolumns inmailstable.Mail Driver Updates
MailgunDriver: IntroducedunsuppressEmailAddressmethod to handle unsuppression of email addresses using Mailgun API.PostmarkDriver: IntroducedunsuppressEmailAddressmethod to handle unsuppression of email addresses using Postmark API.Event and Listener
MailUnsuppressedevent to trigger when an email address is unsuppressed.UnsuppressEmailAddresslistener to handle theMailUnsuppressedevent and call the appropriate mail driver method.Service Provider
MailsServiceProviderto register the newMailUnsuppressedevent and its listener, and to include the new migration. [1] [2] [3]