Fix Looker Classifications handing

app/packages/looker/src/lookers/abstract.ts

@@ -24,6 +24,9 @@ import { Events } from "../elements/base";
 import { COMMON_SHORTCUTS, LookerElement } from "../elements/common";
 import { ClassificationsOverlay, loadOverlays } from "../overlays";
 import { CONTAINS, LabelMask, Overlay } from "../overlays/base";
+import DetectionOverlay from "../overlays/detection";
+import HeatmapOverlay from "../overlays/heatmap";
+import SegmentationOverlay from "../overlays/segmentation";
 import processOverlays from "../processOverlays";
 import {
   BaseState,
@@ -528,10 +531,13 @@ export abstract class AbstractLooker<
     for (const overlay of this.pluckedOverlays ?? []) {
       let overlayData: LabelMask = null;
 
-      if ("mask" in overlay.label) {
-        overlayData = overlay.label.mask as LabelMask;
-      } else if ("map" in overlay.label) {
-        overlayData = overlay.label.map as LabelMask;
+      if (
+        overlay instanceof DetectionOverlay ||
+        overlay instanceof SegmentationOverlay
+      ) {
+        overlayData = overlay.label.mask;
+      } else if (overlay instanceof HeatmapOverlay) {
+        overlayData = overlay.label.map;
       }
 
       const buffer = overlayData?.data?.buffer;
@@ -546,9 +552,9 @@ export abstract class AbstractLooker<
         if (buffer.detached) {
           // most likely sample is already being processed, skip update
           return;
-        } else {
-          arrayBuffers.push(buffer);
         }
+
+        arrayBuffers.push(buffer);
       } else if (buffer.byteLength) {
         // hope we don't run into this edge case (old browser)
         // sometimes detached buffers have bytelength > 0
@@ -743,7 +749,7 @@ export abstract class AbstractLooker<
 
   protected cleanOverlays() {
     for (const overlay of this.sampleOverlays ?? []) {
-      overlay.cleanup();
+      overlay.cleanup?.();
     }
   }
 

app/packages/looker/tsconfig.json

@@ -1,8 +1,8 @@
 {
     "compilerOptions": {
-        "target": "ES2023",
+        "target": "ES2024",
         "module": "ES2022",
-        "lib": ["ES2023", "DOM", "DOM.Iterable"],
+        "lib": ["ES2024", "DOM", "DOM.Iterable"],
         "moduleResolution": "Node",
         "sourceMap": true,
         "resolveJsonModule": true,

app/packages/state/src/utils.ts

@@ -57,15 +57,26 @@ export const stringifyObj = (obj) => {
   );
 };
 
-export const filterView = (stages) =>
+export const filterView = (stages: State.Stage[]) =>
   JSON.stringify(
     stages.map(({ kwargs, _cls }) => ({
       kwargs: kwargs.filter((ka) => !ka[0].startsWith("_")),
       _cls,
     }))
   );
 
-export const viewsAreEqual = (viewOne, viewTwo) => {
+export const viewsAreEqual = (
+  viewOne?: string | State.Stage[],
+  viewTwo?: string | State.Stage[]
+) => {
+  if (viewOne === viewTwo) {
+    return true;
+  }
+
+  if (!Array.isArray(viewOne) || !Array.isArray(viewTwo)) {
+    return false;
+  }
+
   return filterView(viewOne) === filterView(viewTwo);
 };