Array indentation seems broken

[j0ni]

Multiline array literals get formatted like this:

  $nodes = [
            '10.116.1.72',
            '10.116.1.73'
            ]

which seems quite broken. I think they should look like this:

  $nodes = [
    '10.116.1.72',
    '10.116.1.73'
  ]

[swsnr]

It's always been like that, and we'll not touch the existing indentation code before #7.

With #7, these things should be fixed then.

[j0ni]

@lunaryorn sounds right, thanks.

[swsnr]

@j0ni You're welcome! Please report any other indentation flaws you find. While we won't fix them immediately, they show us what we need to look for when implementing SMIE.

[bbatsov]

@lunaryorn This particular SMIE code can be borrowed directly from ruby-mode. I guess we'll be able to borrow from them heavily given the fact that the puppet lang shares some common ground with Ruby.

[swsnr]

@bbatsov I hope so. I actually made my living here by borrowing from Ruby Mode. The string expansion stuff is also conveniently stolen from Ruby Mode ;)

[bbatsov]

I’m well aware of that. :-) I’ve been following @dgutov’s work on ruby-mode closely over the past year or so. He’s one of the best hackers in the community, so borrowing from his work is always a good idea. One can certainly do much worse. :-)

Cheers,
Bozhidar

On Friday, March 14, 2014 at 8:00 PM, Sebastian Wiesner wrote:

@bbatsov (https://github.com/bbatsov) I hope so. I actually made my living here by borrowing from Ruby Mode. The string expansion stuff is also conveniently stolen from Ruby Mode ;)

—
Reply to this email directly or view it on GitHub (#33 (comment)).

[swsnr]

@bbatsov Yeah, indeed. It's a well-written mode, and there's a lot to learn from it.

[dgutov]

😊

Thanks, but ruby-mode still has its share of warts. There's old indentation code left, a few commands still use it even with SMIE integration enabled, and the SMIE grammar is far from perfect, making the indentation code in places more complex than is probably has to be. Sexp movement is also not always intuitive because of that.

[askreet]

Aw, just saw this after fixing this indentation locally. Can I convince you to accept a pull request addressing this while you're working out the details of SMIE?