Fix multi-line array indentation. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askreet
force-pushed
the
FixArrayIndentation
branch
from
04db2ce to
bbdb1d8
Compare
| (goto-char array-start) | ||
| (setq cur-indent (current-indentation)) | ||
| ) | ||
| (progn |
There was a problem hiding this comment.
You need no progn for the else clause. Please remove it.
|
@askreet Sure, I'll merge it, but please address my remarks. And please write a comment when you've done so, because Github doesn't send notifications for updated pull requests, so I'd miss your update otherwise. Thanks :) |
|
@lunaryorn Feedback has been addressed. Thanks for the information, this is the most complex elisp hacking I've done to date, so it was helpful. |
swsnr
added a commit
that referenced
this pull request
Jul 30, 2015
Fix multi-line array indentation.
|
@askreet Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #33 - I know you mentioned wanting to implement SMIE instead of patch the existing implementation. Unfortunately, I didn't see that issue until after I fixed it locally. I understand if you'd prefer to just close this PR in favor of SMIE.