Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binding repl-args when calling make-comint #83

Merged
merged 1 commit into from
Mar 15, 2017

Conversation

rski
Copy link
Member

@rski rski commented Mar 15, 2017

The argument after make-comint's PROGRAM argument is STARTFILE.
Not setting it to nil results in the first value of puppet-repl-args
being bound to it. This is not right, since all of puppet-repl-args
are expected to be flags for the repl command and not STARTFILE.

The argument after make-comint's PROGRAM argument is STARTFILE.
Not setting it to nil results in the first value of puppet-repl-args
being bound to it. This is not right, since all of puppet-repl-args
are expected to be flags for the repl command and not STARTFILE.
@bbatsov bbatsov merged commit 8e5c8b6 into master Mar 15, 2017
@bbatsov bbatsov deleted the fix_make_comint_args branch March 15, 2017 18:12
@bbatsov
Copy link
Contributor

bbatsov commented Mar 15, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants