Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime-vapor): use css vars work with vapor mode #12621

Open
wants to merge 4 commits into
base: vapor
Choose a base branch
from
Open

feat(runtime-vapor): use css vars work with vapor mode #12621

wants to merge 4 commits into from
+387 −53

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 26, 2024 •
edited
Loading

  • Added a new runtime-helper vaporUseCssVars
  • Extracted baseUseCssVars from the existing useCssVars function for reuse in runtime-vapor
    • (1)Included the logic for applying CSS vars in Teleport
    • (2)Included instance.getCssVars for hydration mismatch checks

Not sure if (1) and (2) can be fully reused, but I think they can, so kept them inside baseUseCssVars

@edison1105 edison1105 force-pushed the edison/refactor/vaporUseCssVars branch from dfacf7d to a3f719d Compare December 27, 2024 05:58
@edison1105 edison1105 force-pushed the edison/refactor/vaporUseCssVars branch from e399800 to f6ef75c Compare December 27, 2024 07:19
@edison1105 edison1105 marked this pull request as ready for review December 27, 2024 07:31
@edison1105 edison1105 changed the title feat(cssVars): use css vars work with vapor mode feat(runtime-vapor): use css vars work with vapor mode Dec 27, 2024
@edison1105 edison1105 added the scope: vapor related to vapor mode label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: vapor related to vapor mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edison1105