chore: update vue 2 tests #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking at the changes and I don't quite see how it's related to #3351. Maybe it does handle the "emits" case but I don't see how it would handle class, style, etc. |
|
@rchl I mean I added vue 2.7 tests in this pr 👀 |
|
Thanks for investigating this, but I think we should avoid bypassing the problem in language tools, otherwise vue repo will never fix it, and fixing upstream problems also out of repo scope. |
|
Thanks, I'll rewrite this PR to contain some vue2-related test changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes vuejs/vue#13104, based on #3351
Actually this is a vue 2.7 type issue: it doesn't convert emits to props. However vue 2.7 seemed to be unmaintained, I fix it in language-tools. Also improves JSX compactibility