Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ?import for vite-ignore import for md files #3173

Closed
wants to merge 1 commit into from

Conversation

sapphi-red
Copy link
Contributor

Vite no longer prepends ?import for dynamic imports with vite-ignore: vitejs/vite#14851

I'm not sure if we want to go this way so I'll put this in draft for now.

@brc-dd
Copy link
Member

brc-dd commented Nov 3, 2023

Looks fine to me. I can merge and cut a release if Vite is moving forward with explicitly specifynig ?import with vite-ignore. Please let me know what you guys decide at Vite side.

@sapphi-red
Copy link
Contributor Author

We reverted the PR (vitejs/vite#14866) so I'll close this PR.

@sapphi-red sapphi-red closed this Nov 3, 2023
@sapphi-red sapphi-red deleted the fix/vite-5-compat branch November 3, 2023 07:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants