Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vueRE conflicting with lineNoRE #4247

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix vueRE conflicting with lineNoRE #4247

merged 1 commit into from
Oct 3, 2024

Conversation

Heptazhou
Copy link
Contributor

This resolves, e.g.:

```json-vue:line-numbers
{{ theme }}
```

and

```json-vue:no-line-numbers
{{ theme }}
```

@brc-dd
Copy link
Member

brc-dd commented Oct 3, 2024

Fine with accepting this, but the line numbers will not be reliable if your string contains more than one line:

image image

@brc-dd brc-dd merged commit 2ac64b8 into vuejs:main Oct 3, 2024
8 checks passed
@Heptazhou
Copy link
Contributor Author

@brc-dd Exactly!

Since my config has a markdown: { lineNumbers: true },
*-vue:no-line-numbers helps turn off the broken line number.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants