Directly initialize the ILS driver in the results template instead of…

… having getOfflineMode do it
vufind-org · Jan 15, 2025 · 3f98865 · 3f98865
1 parent 74e57af
commit 3f98865
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/module/VuFind/src/VuFind/ILS/Connection.php b/module/VuFind/src/VuFind/ILS/Connection.php
@@ -968,9 +968,11 @@ public function getHoldsMode()
      */
     public function getOfflineMode($healthCheck = false)
     {
-        // Always initialize the driver so that authentication tokens, if any,
-        // can be saved in the session cache
-        $this->getDriver();
+        // If we have NoILS failover configured, force driver initialization so
+        // we can know we are checking the offline mode against the correct driver.
+        if ($this->hasNoILSFailover()) {
+            $this->getDriver();
+        }
 
         // If we need to perform a health check, try to do a random item lookup
         // before proceeding.

diff --git a/themes/bootstrap3/templates/search/results.phtml b/themes/bootstrap3/templates/search/results.phtml
@@ -53,7 +53,8 @@
 
   // Initialize the ILS driver so authentication tokens (if any) can be written to the session cache
   // since subsequent AJAX calls to the ILS driver can only read from the session cache
-  $this->ils()->getOfflineMode();
+  $this->ils()->getDriver();
+
 ?>
 
 <h1 class="sr-only"><?=$this->escapeHtml($headTitle)?></h1>

diff --git a/themes/bootstrap5/templates/search/results.phtml b/themes/bootstrap5/templates/search/results.phtml
@@ -53,7 +53,7 @@
 
   // Initialize the ILS driver so authentication tokens (if any) can be written to the session cache
   // since subsequent AJAX calls to the ILS driver can only read from the session cache
-  $this->ils()->getOfflineMode();
+  $this->ils()->getDriver();
 ?>
 
 <h1 class="sr-only"><?=$this->escapeHtml($headTitle)?></h1>