Course reserves: minor quality of life improvements (#4096)

vufind-org · Dec 2, 2024 · 6e8fb3d · 6e8fb3d
1 parent 6c84fce
commit 6e8fb3d
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 3 deletions.
diff --git a/config/vufind/config.ini b/config/vufind/config.ini
@@ -2553,6 +2553,7 @@ validateHierarchySequences = true
 ;default = "Enter search terms here..."
 ;Solr = "Search the catalog"
 ;Solr:filtered = "Search the filtered catalog"
+SolrReserves = reserves_search_placeholder
 ;Summon = "Search Summon"
 
 ; This section controls VuFind's social features.

diff --git a/languages/en.ini b/languages/en.ini
@@ -1241,6 +1241,7 @@ Requests = "Requests"
 Reserves = "Reserves"
 Reserves Search = "Reserves Search"
 Reserves Search Results = "Reserves Search Results"
+reserves_search_placeholder = "Search for course, department or instructor"
 reset_filters_button = "Reset Filters"
 result_checkbox_label = "Select result number %%number%%"
 result_count = "%%count%% results"
@@ -1279,7 +1280,7 @@ scholarly_limit = "Limit to articles from scholarly journals"
 Scroll to Load More = "Scroll to Load More"
 Search = "Search"
 Search For = "Search For"
-Search For Items on Reserve = "Search For Items on Reserve"
+Search For Items on Reserve = "Search for Course Reserves"
 Search History = "Search History"
 Search Home = "Search Home"
 Search Mode = "Search Mode"

diff --git a/themes/bootstrap3/templates/search/reservesresults.phtml b/themes/bootstrap3/templates/search/reservesresults.phtml
@@ -13,4 +13,5 @@
         $this->slot('search-heading')->append(' (' . implode(', ', $headingParts) . ')');
     }
     $this->slot('empty-message')->set($this->transEsc('course_reserves_empty_list'));
+    $this->layout()->breadcrumbs = '<li><a href="' . $this->url('search-reserves') . '">' . $this->transEsc('Search For Items on Reserve') . '</a>';
     echo $this->render('search/results.phtml');
diff --git a/themes/bootstrap3/templates/search/reservessearch.phtml b/themes/bootstrap3/templates/search/reservessearch.phtml
@@ -25,7 +25,7 @@
         'aria-label' => $this->translate('search_terms'),
       ];
       if ($placeholder = $this->searchbox()->getPlaceholderText($tabConfig['selected']['id'] ?? $this->searchClassId)) {
-        $searchboxAttributes['placeholder'] = $placeholder;
+        $searchboxAttributes['placeholder'] = $this->translate($placeholder);
       }
       if ($this->searchbox()->autocompleteEnabled('SolrReserves')) {
         $searchboxAttributes['class'] = ' autocomplete form-control searcher:SolrReserves type:Reserves'

diff --git a/themes/bootstrap5/templates/search/reservesresults.phtml b/themes/bootstrap5/templates/search/reservesresults.phtml
@@ -13,4 +13,5 @@
         $this->slot('search-heading')->append(' (' . implode(', ', $headingParts) . ')');
     }
     $this->slot('empty-message')->set($this->transEsc('course_reserves_empty_list'));
+    $this->layout()->breadcrumbs = '<li><a href="' . $this->url('search-reserves') . '">' . $this->transEsc('Search For Items on Reserve') . '</a>';
     echo $this->render('search/results.phtml');
diff --git a/themes/bootstrap5/templates/search/reservessearch.phtml b/themes/bootstrap5/templates/search/reservessearch.phtml
@@ -25,7 +25,7 @@
         'aria-label' => $this->translate('search_terms'),
       ];
       if ($placeholder = $this->searchbox()->getPlaceholderText($tabConfig['selected']['id'] ?? $this->searchClassId)) {
-        $searchboxAttributes['placeholder'] = $placeholder;
+        $searchboxAttributes['placeholder'] = $this->translate($placeholder);
       }
       if ($this->searchbox()->autocompleteEnabled('SolrReserves')) {
         $searchboxAttributes['class'] = ' autocomplete form-control searcher:SolrReserves type:Reserves'