Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend: ProQuest Federated Search Gateway #3991
base: dev
Are you sure you want to change the base?
Add backend: ProQuest Federated Search Gateway #3991
Changes from 45 commits
9263c83
518de13
e6c1cd1
300c51f
df23ce6
0fb4406
0f3021c
ebab982
8305dd5
a23fefc
d77a08d
fc89632
5d5b9d0
896ba94
6ffeaa3
d856c11
b5a7ddd
2d8b4c8
f40b553
a14a801
86abb67
ec2dc6c
4a0b7b5
190abbe
d698830
9670ee6
2e85a0f
d22ff04
1741fb9
f58c0a4
f1c3776
e3824df
645eb82
6b9ce46
2a4c875
f57b5ba
5b9bebd
c483813
37c9675
eb64924
337966f
3de7007
8338a7b
6bd5782
2418fff
651326b
9c33653
87ef65d
19184b6
56c2058
09616b1
ac20d8f
a5863d7
10075c4
f33dd28
a6e7c4b
68cb9eb
b7cdf1b
7ecd9e4
e7888af
5ec7bfc
4b36eb0
2a8fc17
0814acd
2f7531a
35ce055
60de692
96cd4fb
11b8543
ed7c53f
d42f516
5694042
039db68
cab3c23
c2e6276
8248d16
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray Primo reference here. Should we just remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not necessarily wrong (you could??? bring in Primo results at the top) but it's definitely confusing and shout not be there. Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment also seems to be copied from elsewhere and probably not relevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes clearly using Primo.ini as a source was not ideal. I've reverted this to (almost) what it says in facets.ini.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More Primo references here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has anyone tested whether tab/accordion modes work here? Let us know if you'd like @sturkel89 or me to give it a try!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely tested it during development (only added stuff to ProQuest.ini that I tested -- except obviously I copied over a lot of bad Primo comments :) ) but that's definitely not proof it works as designed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure that your connector here does not support search caching. Am I missing something, or should we remove these settings for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be working! It's actually the SRU Connector that uses ConnectorCacheTrait and uses it in search(); looks like I added that in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Sorry for missing that detail -- didn't look high enough in the class hierarchy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I had to check myself anyway, I wrote that part back in October!