[VUFIND-1741] Remove bootstrap3, bootprint3 and sandal themes #4192
Conversation
There was a problem hiding this comment.
Thanks for all the work on this, @EreMaijala -- looking good so far, but see below for a few minor suggestions and comments.
| "watch:less": "grunt watch:less", | ||
| "build-dev:less": "grunt lessdev && npm run lessToSass", | ||
| "watch-dev:less": "grunt watch:lessdev", | ||
| "build:css": "npm run build:scss", |
There was a problem hiding this comment.
Since we're ripping a bunch of stuff out here, we should update the npm wiki page accordingly. I've added a TODO checkbox for the task. I'm not sure if it's best to keep existing documentation but flag things as deprecated/removed, or to fully simplify it. I guess we should probably maintain some legacy documentation for a while, though my gut just wants to get rid of it quickly. :-)
| * | ||
| * @return string | ||
| * | ||
| * @SuppressWarnings(PHPMD.UnusedLocalVariable) | ||
| */ | ||
| protected function makeRelative($css, $less) | ||
| protected function makeRelative($css, $scss) |
There was a problem hiding this comment.
As far as I can tell, this method is never used. Should we just remove it, or am I missing something?
There was a problem hiding this comment.
The whole PHP-based SCSS compilation command is obsolete and doesn't work. But I'd rather remove it in a separate commit.
There was a problem hiding this comment.
I've put this on the next Community Call agenda to discuss. I agree that we should be able to get rid of it, but it seems worth having a brief conversation about.
There was a problem hiding this comment.
@EreMaijala, the code changes look good to me and the test suite is passing, but something is wrong somewhere. Here's what the home page looks like in my test environment -- note missing backgrounds and logos:
Is it possible something was being pulled in via relative path from an old theme, or something like that?
|
Oops, there were a couple of hardcoded paths I'd missed in sandal5. Now fixed. |
There was a problem hiding this comment.
Thanks, @EreMaijala, this is now looking good and passing tests!
demiankatz
added
the
architecture
TODO