Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open collection level by default in hierarchy tree #4201

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

siiriylonen
Copy link
Contributor

@siiriylonen siiriylonen commented Jan 22, 2025

Open collection level by default in hierarchy tree for user convenience.

@siiriylonen siiriylonen marked this pull request as ready for review January 22, 2025 09:29
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @siiriylonen! I think this may require some adjustments, though...

This change will cause every level of the hierarchy tree to be expanded if it is a collection. For large and complex collections, this may result in an overwhelming amount of information to scroll through. Is that really what is intended?

I spoke with @EreMaijala about this, and he thought that the intent might be to only open the top node of the tree if it is a collection and other items are not open/selected. That narrower scope for the special case seems more likely to be universally beneficial (though if "all collections always expanded" is really what you want, maybe we should consider a config setting for that so it doesn't change the default behavior for users that won't want it).

@siiriylonen
Copy link
Contributor Author

I see, yes the intention here was to only open the one and not many. I'll rethink.

@demiankatz
Copy link
Member

Thanks, @siiriylonen! Let me know if I can be of any assistance as you revise. Also note that if you start up the default test environment (with phing startup) it includes some sample collection data that might be useful for testing. To confirm my concerns about the initial version of this code, I just spun up a test instance, turned on collections and hierarchies in config.ini, and then filtered down to the collection.mrc example records. This allowed me to look at a deep nested hierarchy and confirm that all levels opened up with this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants