Adding restricted view warning for EDS #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Jan 24, 2025
themes/bootstrap5/templates/_ui/components/hide-offcanvas-button.phtml
Outdated
Show resolved
Hide resolved
themes/bootstrap5/templates/_ui/components/show-sidebar-button.phtml
Outdated
Show resolved
Hide resolved
| @@ -76,6 +76,10 @@ | |||
| <?php endif; ?> | |||
| <?=$this->record($this->driver)->getLabelList() ?> | |||
|
|
|||
| <?php if (($this->showRestrictedViewWarning ?? false) && $restrictedView): ?> | |||
There was a problem hiding this comment.
You've put this only in the EDS-specific core.phtml. Should we also include it in the DefaultRecord version, on the assumption that this generic mechanism might also be used in other scenarios?
There was a problem hiding this comment.
In the DefaultRecord version we don't have a $restrictedView variable we could use.
There was a problem hiding this comment.
Makes sense -- I think it's fine as it is!
…nd using logginForAcces in more places with better text
demiankatz
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Thanks, @ThoWagen -- just one more minor suggestion below. Once that's updated, I'll find some time for hands-on testing, and hopefully will be able to merge after that!
| @@ -76,6 +76,10 @@ | |||
| <?php endif; ?> | |||
| <?=$this->record($this->driver)->getLabelList() ?> | |||
|
|
|||
| <?php if (($this->showRestrictedViewWarning ?? false) && $restrictedView): ?> | |||
There was a problem hiding this comment.
Makes sense -- I think it's fine as it is!
Co-authored-by: Demian Katz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to display a warning to the users if they only have a restricted view in EDS searches and records.
It also fixes the
loginForAccess.phtmlmessage for users that are already logged in but still lack permission for the full access.