-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to join tables on organisation #4
base: main
Are you sure you want to change the base?
Conversation
02_join/Organisation.R
Outdated
dfTeacher <- readr::read_delim(unz(sMostrecent_zip, "teacher.csv")) | ||
dfGenericTopic <- readr::read_delim(unz(sMostrecent_zip, "genericTopic.csv")) | ||
|
||
## Join the two data frames |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for creating three separate tables?
Can we not combine into a single table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason for creating three separete tables. We can indeed combine into a single table.
Hi @JornGitHub , Please rename the pull request, to make its purpose clear. |
Hi @JornGitHub , A few comments:
And to prevent these suffixes, see example below:
Currently, the organisation table is used as base. However, it seems to be more like a type of mapping table. |
Linked to #3.
Add script to join tables on organisation.