Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading and separator roles to feed's allowed accessibility children #2245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Jun 13, 2024

Closes #2236

Based on the working group discussion of the linked issue, we decided to make a quick PR to add heading & separator to feed, and work on ARIA role content models separately. At some point, the content model approach may replace the heading/separator addition when it's ready.

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

  • "author MUST" tests: N/A
  • "user agent MUST" tests: N/A
  • Browser implementations (link to issue or commit): N/A
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations? no
  • Related APG Issue/PR: N/A
  • MDN Issue/PR: N/A

Preview | Diff

@shirsha
Copy link

shirsha commented Jun 24, 2024

In The feed role , "Authors MAY use heading and separator children in a feed . For example, in a feed of news stories there could be headings separating sets of articles into sequential dates. If a feed does have headings or separators as children, they SHOULD NOT be focusable or contain information necessary for understanding or navigating the feed 's articles ."

Confused with last sentence "If a feed does have headings or separators as children, they SHOULD NOT be focusable or contain information necessary for understanding or navigating the feed 's articles ". May be provide examples like timestamp and name etc. Provide some explicit info

Also, will there be any related info is added to the heading and the separator role?

@giacomo-petri
Copy link
Contributor

Should we consider adding the scrollbar role as an allowed child element?

When dealing with a high but "static" number of articles, showing them on scroll for any reason (e.g. for performance reasons), this setup might be one of the rare cases where an author would want to create a custom scrollbar.
By doing so, it would give the impression that all the content is already fully loaded, allowing users to see the entire scroll progress right from the initial page load.

I understand that the scrollbar can be positioned outside the feed element, but I don't see why the author shouldn't be allowed to place it inside, as the scrollbar is an integral part of the feed document.

Regarding the rest of the addition, I like it. The details about focusability and not including important text are crucial for maintaining a smooth experience for keyboard users.

@smhigley
Copy link
Contributor Author

smhigley commented Jul 8, 2024

Should we consider adding the scrollbar role as an allowed child element?

@giacomo-petri this makes sense to me! Though I think scrollbar should generally be an allowed child of any composite widget, not just feed. Probably as a separate PR, or as part of the roles categorization that @scottaohara mentioned on the last ARIA call -- WDYT?

@smhigley
Copy link
Contributor Author

smhigley commented Jul 8, 2024

@shirsha the sentence you quoted contains an example in it -- "For example, in a feed of news stories there could be headings separating sets of articles into sequential dates." Is that example enough to address your comment, or is there additional information you want included?

I didn't add anything to the heading and separator role sections, since this change doesn't affect their usage outside of feed.

@pkra pkra added the spec:aria label Jul 9, 2024
@css-meeting-bot
Copy link
Member

The ARIA Working Group just discussed review: normative pr checklist.

The full IRC log of that discussion <ZoeBijl> topic: review: normative pr checklist
<ZoeBijl> we refined the checklist after monorepo
<ZoeBijl> https://github.com//pull/2245
<ZoeBijl> Github: https://github.com//pull/2245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding headings to feed's allowed accessibility children
5 participants