Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <selectedcontent> element #528

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

josepharhar
Copy link

@josepharhar josepharhar commented Sep 27, 2024

The <selectedoption> element is part of the customizable select feature and is being added to HTML here.

It is already implemented in chromium and will be shipped when customizable <select> is shipped.


labels: needs implementation commitment, needs changelog entry

Closes #0000

test case


Preview | Diff

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
@scottaohara
Copy link
Member

Noting here that there will need to be an entry for a button as a child of a select as well.

@josepharhar
Copy link
Author

Noting here that there will need to be an entry for a button as a child of a select as well.

Where should I put this?

@josepharhar josepharhar changed the title Add <selectedoption> element Add <selectedcontent> element Nov 12, 2024
@scottaohara
Copy link
Member

Noting here that there will need to be an entry for a button as a child of a select as well.

Where should I put this?

oh no worries @josepharhar that was a note for me, not so much for you.

if you did want to take it on, we'd need a new button as a child of a select entry in the table - using a similar ID like I'm setting up over in html aam el-button-select-child

but really, don't worry about it. i was planning on working on finishing this PR once the HTML/HTML AAM PRs were a bit closer to done.

@scottaohara
Copy link
Member

latest commit updates selectedcontent to align with recent HTML AAM changes.

also added in the button as a child of select variant / expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants