Prevent duplicates in dfns extracts #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the dfns extraction code skip over a re-defined term (same linking text, same type, same namespace), and report a warning when a duplicate dfn is encountered and skipped. Warnings are easily glossed over but we don't really have a better mechanism in place right now to report issues found during extractions. Apart from making the whole extraction fail that is, which seems overkill. Fixes w3c/webref#783
dontcallmedom
approved these changes
Nov 9, 2022
|
I created w3c/webref#789 to track the possibility to do curation on dfns. |
tidoust
added a commit
that referenced
this pull request
Nov 27, 2022
New features: - Auto-legacy mode for dfns extraction (#1120) - Prevent duplicates in dfns extracts (#1110) Dependencies bumped: - Bump rollup from 3.2.5 to 3.5.0 (#1113, #1116, #1122) - Bump web-specs from 2.35.0 to 2.36.0 (#1121) - Bump minimatch from 3.0.4 to 3.1.2 (#1118) - Bump puppeteer from 19.2.2 to 19.3.0 (#1119) - Bump ajv from 8.11.0 to 8.11.2 (#1112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the dfns extraction code skip over a re-defined term (same linking text, same type, same namespace), and report a warning when a duplicate dfn is encountered and skipped.
Warnings are easily glossed over but we don't really have a better mechanism in place right now to report issues found during extractions. Apart from making the whole extraction fail that is, which seems overkill.
Fixes w3c/webref#783