Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capital letters in refs #119

Merged
merged 2 commits into from
Sep 28, 2023
Merged

capital letters in refs #119

merged 2 commits into from
Sep 28, 2023

Conversation

domel
Copy link
Contributor

@domel domel commented Sep 21, 2023

  • unification of items in References - now all items are in capital letters
  • remove vCard from References - now vCard vocab is treated the same as FOAF vocab

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Sep 21, 2023, 4:31 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

📡 HTTP Error 404: http://labs.w3.org/spec-generator/uploads/IGyLAg/spec/index.html

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@domel domel requested a review from hartig September 21, 2023 14:18
@domel domel added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Sep 21, 2023
@domel domel requested a review from rubensworks September 21, 2023 14:19
spec/index.html Outdated
@@ -4582,7 +4582,7 @@ <h4>Descriptions of Resources</h4>
</div>
</div>
<p>which includes the blank node closure for the
<a data-cite="vcard-rdf#" class="inform">vCard vocabulary</a> <code>vcard:N</code>.
vCard vocabulary <code>vcard:N</code>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can be have a link to the vCard vocabulary here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so why not link also to FOAF?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afs And the second question, why is this a normative reference?

Copy link
Member

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Except for the removal of the vCard link as raised by @afs.

requirements identified by the RDF Data Access Working Group in [[rdf-dawg-uc]],
the SPARQL 1.1 Working Group in [[sparql-features]], and the RDF-star Working Group.
requirements identified by the RDF Data Access Working Group in [[RDF-DAWG-UC]],
the SPARQL 1.1 Working Group in [[SPARQL-FEATURES]], and the RDF-star Working Group.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genuine question: do we want these to be normative references?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tpt Agree. The problem is that Informative references are not generated. I don't know why, but I suggest unifying the capital letter issue, and let's clean the HTML/ReSpec in a different PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Task #120

requirements identified by the RDF Data Access Working Group in [[rdf-dawg-uc]],
the SPARQL 1.1 Working Group in [[sparql-features]], and the RDF-star Working Group.
requirements identified by the RDF Data Access Working Group in [[RDF-DAWG-UC]],
the SPARQL 1.1 Working Group in [[SPARQL-FEATURES]], and the RDF-star Working Group.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Task #120

@domel domel merged commit 07a7225 into main Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants