Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions for the base direction feature #172

Merged
merged 18 commits into from
Dec 27, 2024
Merged

Functions for the base direction feature #172

merged 18 commits into from
Dec 27, 2024

Conversation

afs
Copy link
Contributor

@afs afs commented Dec 4, 2024

This addresses #154

#112 has been used for a different discussion.


The SPARQL grammar already has the base direction update #153.

This PR adds the functions LANGDIR, STRLANGDIR, hasLANGDIR and hasLANG.

It includes the non-grammar content from #113 with comments incorporated.


Preview | Diff

@afs afs force-pushed the itd-text branch 4 times, most recently from 6f614fa to 68fd659 Compare December 7, 2024 14:08
@afs afs marked this pull request as ready for review December 8, 2024 10:19
@afs afs force-pushed the itd-text branch 2 times, most recently from ce23520 to 7e5624c Compare December 8, 2024 10:46
@afs
Copy link
Contributor Author

afs commented Dec 10, 2024

Tests: w3c/rdf-tests#156

@afs afs requested review from kasei, hartig, rubensworks and Tpt December 10, 2024 16:15
@afs
Copy link
Contributor Author

afs commented Dec 10, 2024

This PR has changes to the "functions" section which already has the triple term functions text.

Hopefully, it will be robust to other document PRs, short of any bulk reformatting. So there is no rush to review and get this into spec/index.html.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@afs afs self-assigned this Dec 11, 2024
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@pfps pfps added the spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial label Dec 12, 2024
@afs
Copy link
Contributor Author

afs commented Dec 19, 2024

I hope I've addressed all comments.

The check ("Verift common files are consistent") is failing because the "participants" PR has not been merged.

@afs afs requested review from Tpt and hartig December 19, 2024 19:10
@afs
Copy link
Contributor Author

afs commented Dec 20, 2024

Rebased for changes to common files. Preview and diff should be up-to-date.

@afs afs merged commit 8390906 into main Dec 27, 2024
2 checks passed
@afs afs deleted the itd-text branch December 27, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants