Support directional language-tagged strings, Closes #39 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubensworks
added
the
spec:substantive
domel
approved these changes
Oct 25, 2023
gkellogg
approved these changes
Oct 25, 2023
Tpt
reviewed
Nov 2, 2023
domel
approved these changes
Nov 10, 2023
Tpt
reviewed
Nov 11, 2023
spec/output.srx
Outdated
| xsi:schemaLocation="http://www.w3.org/2001/sw/DataAccess/rf1/result2.xsd"> | ||
| xsi:schemaLocation="http://www.w3.org/2001/sw/DataAccess/rf1/result2.xsd" | ||
| xmlns:its="http://www.w3.org/2005/11/its" | ||
| its:version="1.0"> |
There was a problem hiding this comment.
Maybe move to 2.0? (same with output-quoted.srx).
| <sparql xmlns="http://www.w3.org/2005/sparql-results#"> | ||
| <sparql xmlns="http://www.w3.org/2005/sparql-results#" | ||
| xmlns:its="http://www.w3.org/2005/11/its" | ||
| its:version="2.0"> | ||
| ... | ||
| </sparql> | ||
| </pre> |
There was a problem hiding this comment.
I would maybe state that other its:version values are ok to not make migrating to new its version a breaking change in future versions of XML query results.
Tpt
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to w3c/sparql-results-json#33,
"its:dir"was chosen as key to be aligned with"xml:lang"following https://www.w3.org/TR/2007/REC-its-20070403/#att.dirThis requires the
"its"namespace to be added to results that include literals with base directions.Preview | Diff