Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when upgrade to socket.io 3.0.0 #1031

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Fix crash when upgrade to socket.io 3.0.0 #1031

merged 1 commit into from
Nov 12, 2020

Conversation

jennyliang220
Copy link
Contributor

closes #1026 .

@nschonni
Copy link
Contributor

Is there a simple test that could be added to catch future regressions?

@jennyliang220
Copy link
Contributor Author

Is there a simple test that could be added to catch future regressions?

@nschonni There should be one to test if UI is up and running. I create an issue for this, see #1028.

@jennyliang220 jennyliang220 requested a review from deniak November 12, 2020 04:18
@deniak deniak added the bug label Nov 12, 2020
@deniak deniak merged commit db0aa96 into main Nov 12, 2020
@deniak deniak deleted the 1026_fix_socket branch November 12, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniak deniak deniak approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt specberus to socket.io 3.0.0
3 participants
@jennyliang220 @nschonni @deniak