Make sink an argument to get tt compliant attribute value #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
commented
Mar 28, 2024
| @@ -1081,24 +1081,23 @@ Given an {{HTMLScriptElement}} (|script|), this algorithm performs the following | |||
| If the algorithm threw an error, rethrow the error. | |||
|
|
|||
| ## Get Trusted Types-compliant attribute value ## {#validate-attribute-mutation} | |||
| To <dfn abstract-op export>get Trusted Types-compliant attribute value</dfn> on {{Attr}} |attribute| with {{Element}} |element| and {{TrustedType}} or a string |newValue|, perform the following steps: | |||
| To <dfn abstract-op export>get Trusted Types-compliant attribute value</dfn> on {{Attr}} |attribute| with {{Element}} |element|, {{TrustedType}} or a string |newValue|, and string |sink|, perform the following steps: | |||
There was a problem hiding this comment.
Instead of the sink being HTMLIFrameElement srcdoc it will be something like Element setAttribute or Attr value this matches Chrome's behaviour.
There was a problem hiding this comment.
Need to double check which is correct though does Chrome's impl need updating or is the spec currently just wrong in this case?
There was a problem hiding this comment.
Though this change does mean the DOM integration needs to wire through the sinks from the IDL all the way down to the call out to this spec?
|
Matching commit to the DOM spec PR whatwg/dom@6565089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly address #492
Preview | Diff