Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY FOR REVIEW] [Simplified Chinese] Ian, data entry clerk with autism #988

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

heybran
Copy link
Contributor

@heybran heybran commented Nov 26, 2024

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for wai-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b7b851b
🔍 Latest deploy log https://app.netlify.com/sites/wai-website/deploys/67624d145efcc00008f79d18
😎 Deploy Preview https://deploy-preview-988--wai-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 24 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (🔴 down 8 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@heybran
Copy link
Contributor Author

heybran commented Nov 26, 2024

@remibetin, the preview link somehow doesn't work for this deploy preview, it lands on 404, can you remind me what I did wrong?: https://deploy-preview-988--wai-website.netlify.app/people-use-web/user-stories/story-two/zh-hans

@remibetin
Copy link
Member

@heybran The error is caused by line 15. Removing the leading spaces/indentation should fix the problem.

@remibetin
Copy link
Member

@heybran Is this translation ready for review?

@heybran
Copy link
Contributor Author

heybran commented Dec 16, 2024

@remibetin,

Last time I checked it's good but I will give it another check when I have time. I haven't contacted any Chinese organization to inquiry about the translation help yet, but I can set this to Ready For Review once I check it one more time.

@heybran heybran marked this pull request as ready for review December 18, 2024 04:18
@heybran heybran changed the title [Simplified Chinese] Ian, data entry clerk with autism [READY FOR REVIEW] [Simplified Chinese] Ian, data entry clerk with autism Dec 18, 2024
@heybran
Copy link
Contributor Author

heybran commented Dec 18, 2024

@remibetin Pushed a few tiny improvements, now it's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

[Simplified Chinese] Ian, data entry clerk with autism
2 participants