Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block reservation to past date #143

Closed
wants to merge 2 commits into from
Closed

Conversation

gs18113
Copy link
Collaborator

@gs18113 gs18113 commented Jan 26, 2025

NOTE: DO NOT MERGE

리뷰 작성을 위해서는 과거 예약이 필요하기 때문에 해당 PR의 머지를 보류해야 할 것 같습니다.

📌 Feature Description

과거 날짜에 대한 예약의 경우 ReservationUnavailablethrow하도록 구현하였습니다.

🔧 Implementation Details

  • 주요 변경사항 1
  • 주요 변경사항 2
  • 기타 변경사항

✅ Checklist

  • 코드가 컴파일되고 정상적으로 동작
  • 모든 테스트 통과
  • Linter 돌리기
  • 관련 작업 kanban update
  • slack 알림

📝 Related Issues

  • 관련 문제: #

Copy link
Collaborator

@JunBye JunBye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First Reject!

@dennis0405 dennis0405 requested a review from JunBye January 27, 2025 03:08
dennis0405
dennis0405 previously approved these changes Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants