feat: waku store sync 2.0 protocols & tests #3216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
requested review from
darshankabariya,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
This was referenced Dec 17, 2024
|
You can find the image built from this PR at Built from eb0008e |
|
|
||
| reconciliation_roundtrips.observe(roundTrips) | ||
|
|
||
| await conn.close() |
There was a problem hiding this comment.
The conn gets closed after every reconciliation is complete right?
There was a problem hiding this comment.
Yes it's the last step
Ivansete-status
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Third PR for the new Waku store sync 2.0
Include the protocols themselves.
Transfer protocol does not have tests yet.
Specification
Research issue
Changes
N.B. Cannot be merged before #3215
Followed by #3217
Issue