[fix] fix dangerously error on landing #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50 based on this ReactTooltip/react-tooltip#587 (comment)
After this error, there was another server-rendering issue with react-select “Warning: Prop
id
did not match” that I fixed with a fixed instanceId. A better fix would be to use the useId() hook but it's only available on React 18.import React, { useId } from 'react';
There is one remaining issue for mac devices only I think
Extra attributes from the server: aria-activedescendant
.Everything seems linked to the fact that react-select does not render isomorphically.
There is an attempt to fix it specifically here, I'd suggest to wait and see if the PR get merged