Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Embedded SDK #623

Draft
wants to merge 33 commits into
base: development
Choose a base branch
from

Conversation

Danziger
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ar-connect-embedded ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 9:26pm

@Danziger Danziger marked this pull request as draft January 23, 2025 19:58
@Danziger Danziger marked this pull request as ready for review January 24, 2025 15:26
@Danziger Danziger changed the title Add scaffolding for the Embedded SDK and API. feat: Add scaffolding for the Embedded SDK and API. Jan 24, 2025
shim.d.ts Show resolved Hide resolved
}
});

resizeObserver.observe(mainElement);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be notifying the parent about any change in size due to images loading, elements appearing/disappearing, etc.

Base automatically changed from epic/embedded-wallet to development January 24, 2025 16:25
}: PostEmbeddedMessageData<K>) {
if (!type.startsWith("embedded_"))
throw new Error(
`Only "embedded_auth", "embedded_balance", "embedded_resize" or "embedded_data" can be posted to the upper frame.`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

embedded_data is this intentional ? embedded_close is missing i guess based on map in types file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, the last should be embedded_close. I've pushed commit with the correct code.

Copy link
Contributor

@7i7o 7i7o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 👍

shim.d.ts Show resolved Hide resolved
@Danziger Danziger changed the title feat: Add scaffolding for the Embedded SDK and API. feat: Embedded SDK Feb 7, 2025
@Danziger Danziger marked this pull request as draft February 7, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants