Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not clean stopping #34

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Fix not clean stopping #34

merged 4 commits into from
Sep 29, 2024

Conversation

wasilukm
Copy link
Owner

@wasilukm wasilukm commented Sep 29, 2024

hoymiles-mqtt was not stopping cleanly, many threads were left forever and consuming CPU power. Support for system signals was introduced for graceful process termination.
Additionally, logging was reworked to not log events from sub-dependencies (they were spamming logs).

Fixes #33

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 18.33333% with 49 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (ca10b3d) to head (7d9599f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hoymiles_mqtt/runners.py 5.76% 48 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   76.53%   73.26%   -3.28%     
==========================================
  Files           5        5              
  Lines         277      288      +11     
  Branches       45       45              
==========================================
- Hits          212      211       -1     
- Misses         56       67      +11     
- Partials        9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wasilukm wasilukm merged commit 99f6ca3 into main Sep 29, 2024
4 of 6 checks passed
@wasilukm wasilukm deleted the mwasilu/improve/exception_handling branch January 19, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hoymiles-mqtt becomes unresponsive
1 participant