Skip to content

Commit

Permalink
Make default workspace icon the Wave logo (#1470)
Browse files Browse the repository at this point in the history
I made our logo a custom icon in Font Awesome so we can add it to our
workspace switcher as the default icon
  • Loading branch information
esimkowitz authored Dec 10, 2024
1 parent 8957e04 commit c2312f1
Show file tree
Hide file tree
Showing 9 changed files with 40 additions and 12 deletions.
1 change: 1 addition & 0 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const config: StorybookConfig = {
<link rel="stylesheet" href="./fontawesome/css/solid.min.css" />
<link rel="stylesheet" href="./fontawesome/css/sharp-solid.min.css" />
<link rel="stylesheet" href="./fontawesome/css/sharp-regular.min.css" />
<link rel="stylesheet" href="./fontawesome/css/custom-icons.min.css" />
<style>
#storybook-docs {
[id^="anchor--"],
Expand Down
28 changes: 28 additions & 0 deletions assets/wave-logo_icon-black.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions frontend/app/tab/workspaceswitcher.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const colors = [
];

const icons = [
"circle",
"custom@wave-logo-solid",
"triangle",
"star",
"heart",
Expand Down Expand Up @@ -93,7 +93,7 @@ const IconSelector = memo(({ icons, selectedIcon, onSelect, className }: IconSel
return (
<div className={clsx("icon-selector", className)}>
{icons.map((icon) => {
const iconClass = makeIconClass(icon, false);
const iconClass = makeIconClass(icon, true);
return (
<i
key={icon}
Expand Down
5 changes: 5 additions & 0 deletions frontend/util/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,11 @@ function makeIconClass(icon: string, fw: boolean, opts?: { spin?: boolean; defau
icon = icon.replace(/^brands@/, "");
return clsx(`fa fa-brands fa-${icon}`, fw ? "fa-fw" : null, opts?.spin ? "fa-spin" : null);
}
if (icon.match(/^custom@[a-z0-9-]+$/)) {
// strip off the "custom@" prefix if it exists
icon = icon.replace(/^custom@/, "");
return clsx(`fa fa-kit fa-${icon}`, fw ? "fa-fw" : null, opts?.spin ? "fa-spin" : null);
}
if (opts?.defaultIcon != null) {
return makeIconClass(opts.defaultIcon, fw, { spin: opts?.spin });
}
Expand Down
1 change: 1 addition & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<link rel="stylesheet" href="/fontawesome/css/solid.min.css" />
<link rel="stylesheet" href="/fontawesome/css/sharp-solid.min.css" />
<link rel="stylesheet" href="/fontawesome/css/sharp-regular.min.css" />
<link rel="stylesheet" href="/fontawesome/css/custom-icons.min.css" />
<script type="module" src="frontend/wave.ts"></script>
</head>
<body class="init">
Expand Down
2 changes: 1 addition & 1 deletion pkg/wcore/wcore.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func EnsureInitialData() error {
return nil
}
log.Println("client has no windows, creating starter workspace")
starterWs, err := CreateWorkspace(ctx, "Starter workspace", "circle", "#58C142", true)
starterWs, err := CreateWorkspace(ctx, "Starter workspace", "custom@wave-logo-solid", "#58C142", true)
if err != nil {
return fmt.Errorf("error creating starter workspace: %w", err)
}
Expand Down
1 change: 1 addition & 0 deletions public/fontawesome/css/custom-icons.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 1 addition & 9 deletions public/fontawesome/css/fontawesome.min.css

Large diffs are not rendered by default.

Binary file added public/fontawesome/webfonts/custom-icons.woff2
Binary file not shown.

0 comments on commit c2312f1

Please sign in to comment.