Skip to content

Commit

Permalink
Update our build workflows to use NodeJS 22 (#1285)
Browse files Browse the repository at this point in the history
NodeJS 20 is almost EOL so I'm updating our workflows to use NodeJS 22.
This does not change anything about our app, which will still use NodeJS
20 until Electron shifts away from it. NodeJS 22 is fully
backwards-compatible with NodeJS 20 so there's no issue from a testing
standpoint.
  • Loading branch information
esimkowitz authored Nov 14, 2024
1 parent f4439eb commit e5f98c6
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-helper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
workflow_dispatch:
env:
GO_VERSION: "1.22"
NODE_VERSION: "20"
NODE_VERSION: 22
STATIC_DOCSITE_PATH: docsite
jobs:
build-docsite:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bump-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:
type: boolean
default: true
env:
NODE_VERSION: "20"
NODE_VERSION: 22
jobs:
bump-version:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
- cron: "36 5 * * 5"

env:
NODE_VERSION: "20"
NODE_VERSION: 22
GO_VERSION: "1.22.5"

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-docsite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Docsite and Storybook CI/CD
run-name: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' && 'Build and Deploy' || 'Test Build' }} Docsite and Storybook

env:
NODE_VERSION: 20
NODE_VERSION: 22

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testdriver.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:

env:
GO_VERSION: "1.22"
NODE_VERSION: "20"
NODE_VERSION: 22

permissions:
contents: read # To allow the action to read repository contents
Expand Down
2 changes: 1 addition & 1 deletion BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Download and install Go via your package manager or directly from the website: h

### NodeJS

Make sure you have a NodeJS 20 LTS installed.
Make sure you have a NodeJS 22 LTS installed.

See NodeJS's website for platform-specific instructions: https://nodejs.org/en/download

Expand Down

0 comments on commit e5f98c6

Please sign in to comment.