Skip to content

Commit

Permalink
Add more comments
Browse files Browse the repository at this point in the history
  • Loading branch information
munan-geo committed Aug 13, 2024
1 parent d8c90fe commit fb978c6
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/AeroSharp/Connection/ConnectionConfiguration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ public ConnectionConfiguration()
ConnectionTimeout = TimeSpan.FromSeconds(10);
AsyncMaxCommands = 500;
MaxCommandAction = MaxCommandAction.DELAY; // Recommended by Aerospike Enterprise Support (behavior when asyncMaxCommands is exceeded)
MaxConnsPerNode = 100; // Leave it as default value from Aerospike
// Leave it as default value from Aerospike Client.

Check warning on line 21 in src/AeroSharp/Connection/ConnectionConfiguration.cs

View workflow job for this annotation

GitHub Actions / integration

Check warning on line 21 in src/AeroSharp/Connection/ConnectionConfiguration.cs

View workflow job for this annotation

GitHub Actions / integration

Check warning on line 21 in src/AeroSharp/Connection/ConnectionConfiguration.cs

View workflow job for this annotation

GitHub Actions / unit

Check warning on line 21 in src/AeroSharp/Connection/ConnectionConfiguration.cs

View workflow job for this annotation

GitHub Actions / unit

// Note: Aerospike client has updated their default settings, see the change reasons from Aerospike forum: https://discuss.aerospike.com/t/client-1772-client-configurations-changes-reasons/9699
// We will update AsyncMaxCommands to 100 when we bump up Aerospike version so we align with Aerospike settings.
// Relationship between asyncMaxConnsPerNode and MaxConnsPerNode can be found from here: https://aerospike.com/apidocs/csharp/html/f_aerospike_client_asyncclientpolicy_asyncmaxconnspernode
MaxConnsPerNode = 100;
}

/// <summary>
Expand Down

0 comments on commit fb978c6

Please sign in to comment.