Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more media keys and features #2351

Merged
merged 38 commits into from
Jan 16, 2025
Merged

Conversation

autonome
Copy link
Collaborator

@autonome autonome commented Nov 27, 2024

Pulled in all the media-related spec-drafts. Some new features, some merges of keys.

Feedback on these would be good:

  • I went for a "media-*" pattern for keys/filename. CSS and media APIs both falling in that pattern isn't ideal, but doesn't seem like a huge deal.

  • There's a media-elements group, but maybe we need a media-apis or media-handling group also?

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 27, 2024
@autonome autonome marked this pull request as ready for review November 27, 2024 16:56
@autonome autonome marked this pull request as draft November 27, 2024 17:26
@autonome autonome marked this pull request as ready for review November 27, 2024 17:48
@autonome autonome requested a review from ddbeck December 16, 2024 16:12
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several suggestions here, but nothing earth shattering. Thank you!

features/encrypted-media.yml Outdated Show resolved Hide resolved
features/encrypted-media.yml Outdated Show resolved Hide resolved
features/encrypted-media.yml Outdated Show resolved Hide resolved
features/encrypted-media.yml Outdated Show resolved Hide resolved
features/media-capabilities.yml Outdated Show resolved Hide resolved
features/media-recording.yml Outdated Show resolved Hide resolved
features/media-recording.yml Outdated Show resolved Hide resolved
features/media-transform.yml Outdated Show resolved Hide resolved
features/media-transform.yml Outdated Show resolved Hide resolved
features/media-transform.yml Outdated Show resolved Hide resolved
@autonome autonome requested a review from ddbeck January 15, 2025 21:09
@ddbeck ddbeck merged commit 3e8ffe2 into web-platform-dx:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants