Skip to content

Commit

Permalink
Add dev server test data for an experimental run of Edge
Browse files Browse the repository at this point in the history
This adds a test run for edge experimental on the testing sha
24278ab. It reuses the same json results as edge[stable]. The goal is
to make the webdriver tests more like reality (e.g. there should be 4
experimental browsers by default) and to allow us to remove the obsolete
experimentalAlignedExceptEdge flag (which is off in prod/staging but
still on for the dev server!)
  • Loading branch information
stephenmcgruer committed Mar 5, 2021
1 parent e9d3fdb commit a8090ef
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
6 changes: 6 additions & 0 deletions util/populate_dev_data.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ func main() {
edge.ResultsURL = fmt.Sprintf(summaryURLFmtString, *localHost, staticRunSHA[:10], "edge[stable].json")
edge.Labels = []string{"edge", shared.StableLabel}

edgeExp := edge
edgeExp.BrowserVersion = "20"
edgeExp.ResultsURL = strings.Replace(edge.ResultsURL, "[stable]", "[experimental]", -1)
edgeExp.Labels = []string{"edge", shared.ExperimentalLabel}

firefox := chrome
firefox.BrowserName = "firefox"
firefox.BrowserVersion = "66"
Expand All @@ -115,6 +120,7 @@ func main() {
chrome,
chromeExp,
edge,
edgeExp,
firefox,
firefoxExp,
safari,
Expand Down
1 change: 1 addition & 0 deletions webapp/static/24278ab617/edge[experimental].json

Large diffs are not rendered by default.

9 changes: 2 additions & 7 deletions webdriver/label_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,8 @@ import (

func TestLabelParam_Results(t *testing.T) {
runWebdriverTest(t, func(t *testing.T, app AppServer, wd selenium.WebDriver) {
// Local static data only have 2 experimental browsers, and neither has aligned
// experimental runs.
if *staging {
testLabel(t, wd, app, "/", "experimental", "wpt-results", 4, false)
} else {
testLabel(t, wd, app, "/", "experimental", "wpt-results", 3, false)
}
aligned := false
testLabel(t, wd, app, "/", "experimental", "wpt-results", 4, aligned)
})

}
Expand Down

0 comments on commit a8090ef

Please sign in to comment.